Add unstack
#604
Merged
Add unstack
#604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
requested changes
Mar 8, 2023
There was a problem hiding this comment.
This looks good overall, just some minor comments.
The axis=0 default is right, and the return type should indeed be tuple. I cross-checked with torch.unbind and tf.unstack, and the latter gets the return type wrong: it's annotated as Sequence[Any] and the code can return a list. We've learned that a tuple is better, since this should not be appended to, and a list is actually problematic for at least Numba.
|
Merged now, thanks @steff456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
unstackto the specification, fixes #487.