-
Notifications
You must be signed in to change notification settings - Fork 53
Add pre commit + black #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nstarman. The black
reformatting looks like an improvement, in particular the signatures using one line per argument. I'm +1 on that change.
The larger style problem in this repo is that the docstring text doesn't have proper line breaks. I've looked at that before and unfortunately there's no tool that can deal with that automatically.
For pre-commit: I'd be fine with adding a check to CI (either pre-commit or simply black
running in a CI job). However, I'd much prefer to get no bot PRs, those are just noise for both contributors watching the repo and in the commit history. Can we get this without autoupdate_schedule
?
At Astropy we've just started to use PyQA's
Yes, using the GH action |
Thanks! I tried some tools last year, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nstarman, this is looking pretty good to me now. Only one more comment.
basic layout Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
89eb65f
to
da75f85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks a lot @nstarman.
I'll plan to squash-merge this very soon, and then push a follow-up commit with a new .git-blame-ignore-revs
entry.
A maintainer will need to turn on
pre-commit.ci
to enforce pre-commit in the CI.