feat: add cumulative_prod specification
#793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
API extension
|
#797 is relevant here too. |
kgryte
added
the
Needs Changes
kgryte
removed
the
Needs Changes
|
Update: I've added a note similar to what's suggested for |
|
As this PR has not received any objections since April 18, is consistent with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
cumulative_prodto the specification for computing the cumulative product.cumulative_sumin matchingaxis,dtype, andinclude_initialsemantics.cumulative_sum, this specification differs from NumPy in that flattening is not the default behavior. Similar to PyTorch, anaxisargument is required if the input array has more than one dimension.