595-bug-refactor availability num of severity type #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalbl
approved these changes
Mar 10, 2021
yuvalbl
reviewed
Mar 10, 2021
| }, | ||
| })); | ||
|
|
||
| const extractCount = ({ severity_fatal_count, severity_light_count, severity_severe_count }: any) => { |
Collaborator
There was a problem hiding this comment.
@danielsh28 can you explain this function?
why extractCount may return null?
yuvalbl
approved these changes
Mar 10, 2021
yuvalbl
approved these changes
Mar 17, 2021
yuvalbl
deleted the
bug-595-severe_accidents_doesnt_show_in_accident_count_by_severity_widget
branch
yuvalbl
added a commit
that referenced
this pull request
Mar 31, 2021
* Update deploy-master.yml * Update deploy-euro.yml * alter arrow color to black (#496) * Update and rename deploy-euro.yml to deploy-demo.yml * Update deploy-dev.yml * Update deploy-master.yml * change euro env to demo update readme * add demo env file (#500) update readme * Update deploy-demo.yml * Update README.md * Update deploy-dev.yml * Update deploy-demo.yml * Update deploy-master.yml * fix rtl layout (#507) * refactor card change title source (#486) * change title * added IWidgetDataBase interface * add optional to title key * add optional to title key * fix- change ReactLeafletGoogleLayer map Type (#509) * Refactor 492 add text in the bottom of each widget (#508) * added footer component and date comment from meta response on footer, also changed positon of action buttons * fix review comments and added prettierrc file and deleted prettier config from packege.json * vars removes, also removed REACT_APP_ANYWAY_APP_BASE_URL- an unused var (#537) * Refactor 484 card dialog box remove landscape functionality (#506) * refactor-change layout functionality to size * refactor-chnaged sizeOption to number type * refactor cardEditorDialog remove empty box * Feat 498 most severe accidents table modify (#536) * Column added, color removed, title changed * Order accidents by date (ascending) * format date Co-authored-by: sejoB <[email protected]> * fix i18 warnings (#542) * [Fix-497]-head collisions comparison (#512) * rm pie chart angle * changed text * update sb, added HeadOnCollisionsComparisonWidget story * added WidgetsTemplate story * moved small pie that hides big pie * rm unused code * start pie from 12 oclock instead of 15 * changed js files to ts, rm unused code Co-authored-by: Almog Langleben <[email protected]> * Feat-503 create operational cards list (#538) * feat add operationCards list with process.env * refactor widget data service as per PR comment * change REACT_APP_SHOW_ONLY_OPER_CARDS to false * refactor process.env- showOnlyOperCards * refactor processWidgetsFetchResponse * refactor getOperWidgetData * Bump axios from 0.19.2 to 0.21.1 (#549) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Feat-530] Add info icon to card (#545) * add info icon to card (#530) * add tooltip to info icon (#530) * hide info icon on card (#530) * resolve tooltip warning (#530) * refactor #504 textView (#547) * hotfix REACT_APP_SHOW_ONLY_OPER_CARDS (#556) * location map - tooltip location is misplaced (#555) * Refactor 490 remove text at road (#566) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file Co-authored-by: Yael Luria <[email protected]> * Refactor 491 textview add road on top left (#565) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * fix redundant components and interfaces * added additional fixes * change widget header variant * fix merge issues Co-authored-by: Yael Luria <[email protected]> * [Feat-526] add social share buttons (#550) * install react-share and create SocialShare Atom * Add SocialShare below Cards * convert styling to use Box * [Feat-489] Show description on show more (#546) * show description on show more (#489) * show description on show more only on title and description mismatch (#489) * show only description on show more (#489) * add border to table closes #557 (#570) * hotfix injured_count_per_age_group * hotfix InjuredCountPerAgeGroupPieWidget * Refactor 490 remove text at road (#569) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * fixes following review Co-authored-by: Yael Luria <[email protected]> * implement widget injured accidents with pedestrian (#563) * implement widget injured accidents with pedestrian * add legend & refactor per comments * [Refactor-411] update packages (#578) * npm update and fix ts errors * change ts fixing implementation * Refactor 495 pixel perfect design (#571) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review Co-authored-by: Yael Luria <[email protected]> * [Fix-553] Head on collision design review (#567) * background image margin (#553) * pie chart shadow (#553) * card content alignment (#553) * adjust shadow (#553) * CR * CR (#553) * center label for single slice (#553) * lint (#553) * use theme spacing Co-authored-by: yuvalbl <[email protected]> * update operational widgets list (#581) * v0.2.0 * hotfix getOperWidgetData * Update Release.md * Ms3 minor issues (#591) * minor card fixes * table minor fixes * fix i18n * [Refactor/BUG] remove default mock data (#599) * Refactor fix review comments on pr 571 (#580) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review * refactoring after review Co-authored-by: Yael Luria <[email protected]> * [refactor-572] - replace meta tag content (#610) Replace meta tag content. * move text outside the chart (#615) * remove cors error and update auth serer urls in env files (#612) * Feat 558 header center break titles (#598) * break long title in header center variant closes #558 * 595-bug-refactor availability num of severity type (#614) * feat-561-implement-localization-api (#625) * add support for localization api * remove comment * [feat-552] Add label to header varient (#623) * [feat-552] Add label to header varient * [feat-552] fix code after code review * [feat-552] add opacity * [feat-552] refactor style * fix header text view (#624) * bug 628 card header have duplicate variables (#629) * fix card heder duplicates * fix unused import * 592- refactor -pie conditional label on '0' value (#613) Co-authored-by: danielsh28 <[email protected]> Co-authored-by: SejoB <[email protected]> Co-authored-by: Eyal Levi <[email protected]> Co-authored-by: Adele Angel <[email protected]> Co-authored-by: sejoB <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yoav Porat <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Idan Levian <[email protected]>
yuvalbl
added a commit
that referenced
this pull request
Mar 31, 2021
* Update deploy-master.yml * Update deploy-euro.yml * alter arrow color to black (#496) * Update and rename deploy-euro.yml to deploy-demo.yml * Update deploy-dev.yml * Update deploy-master.yml * change euro env to demo update readme * add demo env file (#500) update readme * Update deploy-demo.yml * Update README.md * Update deploy-dev.yml * Update deploy-demo.yml * Update deploy-master.yml * fix rtl layout (#507) * refactor card change title source (#486) * change title * added IWidgetDataBase interface * add optional to title key * add optional to title key * fix- change ReactLeafletGoogleLayer map Type (#509) * Refactor 492 add text in the bottom of each widget (#508) * added footer component and date comment from meta response on footer, also changed positon of action buttons * fix review comments and added prettierrc file and deleted prettier config from packege.json * vars removes, also removed REACT_APP_ANYWAY_APP_BASE_URL- an unused var (#537) * Refactor 484 card dialog box remove landscape functionality (#506) * refactor-change layout functionality to size * refactor-chnaged sizeOption to number type * refactor cardEditorDialog remove empty box * Feat 498 most severe accidents table modify (#536) * Column added, color removed, title changed * Order accidents by date (ascending) * format date Co-authored-by: sejoB <[email protected]> * fix i18 warnings (#542) * [Fix-497]-head collisions comparison (#512) * rm pie chart angle * changed text * update sb, added HeadOnCollisionsComparisonWidget story * added WidgetsTemplate story * moved small pie that hides big pie * rm unused code * start pie from 12 oclock instead of 15 * changed js files to ts, rm unused code Co-authored-by: Almog Langleben <[email protected]> * Feat-503 create operational cards list (#538) * feat add operationCards list with process.env * refactor widget data service as per PR comment * change REACT_APP_SHOW_ONLY_OPER_CARDS to false * refactor process.env- showOnlyOperCards * refactor processWidgetsFetchResponse * refactor getOperWidgetData * Bump axios from 0.19.2 to 0.21.1 (#549) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Feat-530] Add info icon to card (#545) * add info icon to card (#530) * add tooltip to info icon (#530) * hide info icon on card (#530) * resolve tooltip warning (#530) * refactor #504 textView (#547) * hotfix REACT_APP_SHOW_ONLY_OPER_CARDS (#556) * location map - tooltip location is misplaced (#555) * Refactor 490 remove text at road (#566) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file Co-authored-by: Yael Luria <[email protected]> * Refactor 491 textview add road on top left (#565) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * fix redundant components and interfaces * added additional fixes * change widget header variant * fix merge issues Co-authored-by: Yael Luria <[email protected]> * [Feat-526] add social share buttons (#550) * install react-share and create SocialShare Atom * Add SocialShare below Cards * convert styling to use Box * [Feat-489] Show description on show more (#546) * show description on show more (#489) * show description on show more only on title and description mismatch (#489) * show only description on show more (#489) * add border to table closes #557 (#570) * hotfix injured_count_per_age_group * hotfix InjuredCountPerAgeGroupPieWidget * Refactor 490 remove text at road (#569) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * fixes following review Co-authored-by: Yael Luria <[email protected]> * implement widget injured accidents with pedestrian (#563) * implement widget injured accidents with pedestrian * add legend & refactor per comments * [Refactor-411] update packages (#578) * npm update and fix ts errors * change ts fixing implementation * Refactor 495 pixel perfect design (#571) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review Co-authored-by: Yael Luria <[email protected]> * [Fix-553] Head on collision design review (#567) * background image margin (#553) * pie chart shadow (#553) * card content alignment (#553) * adjust shadow (#553) * CR * CR (#553) * center label for single slice (#553) * lint (#553) * use theme spacing Co-authored-by: yuvalbl <[email protected]> * update operational widgets list (#581) * v0.2.0 * hotfix getOperWidgetData * Update Release.md * Ms3 minor issues (#591) * minor card fixes * table minor fixes * fix i18n * [Refactor/BUG] remove default mock data (#599) * Refactor fix review comments on pr 571 (#580) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review * refactoring after review Co-authored-by: Yael Luria <[email protected]> * [refactor-572] - replace meta tag content (#610) Replace meta tag content. * move text outside the chart (#615) * remove cors error and update auth serer urls in env files (#612) * Feat 558 header center break titles (#598) * break long title in header center variant closes #558 * 595-bug-refactor availability num of severity type (#614) * feat-561-implement-localization-api (#625) * add support for localization api * remove comment * [feat-552] Add label to header varient (#623) * [feat-552] Add label to header varient * [feat-552] fix code after code review * [feat-552] add opacity * [feat-552] refactor style * fix header text view (#624) * bug 628 card header have duplicate variables (#629) * fix card heder duplicates * fix unused import * 592- refactor -pie conditional label on '0' value (#613) Co-authored-by: danielsh28 <[email protected]> Co-authored-by: SejoB <[email protected]> Co-authored-by: Eyal Levi <[email protected]> Co-authored-by: Adele Angel <[email protected]> Co-authored-by: sejoB <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yoav Porat <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Idan Levian <[email protected]>
yuvalbl
added a commit
that referenced
this pull request
Feb 9, 2022
* v0.2.1 (#584) * Update deploy-master.yml * Update deploy-euro.yml * alter arrow color to black (#496) * Update and rename deploy-euro.yml to deploy-demo.yml * Update deploy-dev.yml * Update deploy-master.yml * change euro env to demo update readme * add demo env file (#500) update readme * Update deploy-demo.yml * Update README.md * Update deploy-dev.yml * Update deploy-demo.yml * Update deploy-master.yml * fix rtl layout (#507) * refactor card change title source (#486) * change title * added IWidgetDataBase interface * add optional to title key * add optional to title key * fix- change ReactLeafletGoogleLayer map Type (#509) * Refactor 492 add text in the bottom of each widget (#508) * added footer component and date comment from meta response on footer, also changed positon of action buttons * fix review comments and added prettierrc file and deleted prettier config from packege.json * vars removes, also removed REACT_APP_ANYWAY_APP_BASE_URL- an unused var (#537) * Refactor 484 card dialog box remove landscape functionality (#506) * refactor-change layout functionality to size * refactor-chnaged sizeOption to number type * refactor cardEditorDialog remove empty box * Feat 498 most severe accidents table modify (#536) * Column added, color removed, title changed * Order accidents by date (ascending) * format date Co-authored-by: sejoB <[email protected]> * fix i18 warnings (#542) * [Fix-497]-head collisions comparison (#512) * rm pie chart angle * changed text * update sb, added HeadOnCollisionsComparisonWidget story * added WidgetsTemplate story * moved small pie that hides big pie * rm unused code * start pie from 12 oclock instead of 15 * changed js files to ts, rm unused code Co-authored-by: Almog Langleben <[email protected]> * Feat-503 create operational cards list (#538) * feat add operationCards list with process.env * refactor widget data service as per PR comment * change REACT_APP_SHOW_ONLY_OPER_CARDS to false * refactor process.env- showOnlyOperCards * refactor processWidgetsFetchResponse * refactor getOperWidgetData * Bump axios from 0.19.2 to 0.21.1 (#549) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Feat-530] Add info icon to card (#545) * add info icon to card (#530) * add tooltip to info icon (#530) * hide info icon on card (#530) * resolve tooltip warning (#530) * refactor #504 textView (#547) * hotfix REACT_APP_SHOW_ONLY_OPER_CARDS (#556) * location map - tooltip location is misplaced (#555) * Refactor 490 remove text at road (#566) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file Co-authored-by: Yael Luria <[email protected]> * Refactor 491 textview add road on top left (#565) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * fix redundant components and interfaces * added additional fixes * change widget header variant * fix merge issues Co-authored-by: Yael Luria <[email protected]> * [Feat-526] add social share buttons (#550) * install react-share and create SocialShare Atom * Add SocialShare below Cards * convert styling to use Box * [Feat-489] Show description on show more (#546) * show description on show more (#489) * show description on show more only on title and description mismatch (#489) * show only description on show more (#489) * add border to table closes #557 (#570) * hotfix injured_count_per_age_group * hotfix InjuredCountPerAgeGroupPieWidget * Refactor 490 remove text at road (#569) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * fixes following review Co-authored-by: Yael Luria <[email protected]> * implement widget injured accidents with pedestrian (#563) * implement widget injured accidents with pedestrian * add legend & refactor per comments * [Refactor-411] update packages (#578) * npm update and fix ts errors * change ts fixing implementation * Refactor 495 pixel perfect design (#571) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review Co-authored-by: Yael Luria <[email protected]> * [Fix-553] Head on collision design review (#567) * background image margin (#553) * pie chart shadow (#553) * card content alignment (#553) * adjust shadow (#553) * CR * CR (#553) * center label for single slice (#553) * lint (#553) * use theme spacing Co-authored-by: yuvalbl <[email protected]> * update operational widgets list (#581) * v0.2.0 * hotfix getOperWidgetData Co-authored-by: danielsh28 <[email protected]> Co-authored-by: SejoB <[email protected]> Co-authored-by: Eyal Levi <[email protected]> Co-authored-by: Adele Angel <[email protected]> Co-authored-by: sejoB <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yoav Porat <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Yael Luria <[email protected]> * v0.3.0 (#631) * Update deploy-master.yml * Update deploy-euro.yml * alter arrow color to black (#496) * Update and rename deploy-euro.yml to deploy-demo.yml * Update deploy-dev.yml * Update deploy-master.yml * change euro env to demo update readme * add demo env file (#500) update readme * Update deploy-demo.yml * Update README.md * Update deploy-dev.yml * Update deploy-demo.yml * Update deploy-master.yml * fix rtl layout (#507) * refactor card change title source (#486) * change title * added IWidgetDataBase interface * add optional to title key * add optional to title key * fix- change ReactLeafletGoogleLayer map Type (#509) * Refactor 492 add text in the bottom of each widget (#508) * added footer component and date comment from meta response on footer, also changed positon of action buttons * fix review comments and added prettierrc file and deleted prettier config from packege.json * vars removes, also removed REACT_APP_ANYWAY_APP_BASE_URL- an unused var (#537) * Refactor 484 card dialog box remove landscape functionality (#506) * refactor-change layout functionality to size * refactor-chnaged sizeOption to number type * refactor cardEditorDialog remove empty box * Feat 498 most severe accidents table modify (#536) * Column added, color removed, title changed * Order accidents by date (ascending) * format date Co-authored-by: sejoB <[email protected]> * fix i18 warnings (#542) * [Fix-497]-head collisions comparison (#512) * rm pie chart angle * changed text * update sb, added HeadOnCollisionsComparisonWidget story * added WidgetsTemplate story * moved small pie that hides big pie * rm unused code * start pie from 12 oclock instead of 15 * changed js files to ts, rm unused code Co-authored-by: Almog Langleben <[email protected]> * Feat-503 create operational cards list (#538) * feat add operationCards list with process.env * refactor widget data service as per PR comment * change REACT_APP_SHOW_ONLY_OPER_CARDS to false * refactor process.env- showOnlyOperCards * refactor processWidgetsFetchResponse * refactor getOperWidgetData * Bump axios from 0.19.2 to 0.21.1 (#549) Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Feat-530] Add info icon to card (#545) * add info icon to card (#530) * add tooltip to info icon (#530) * hide info icon on card (#530) * resolve tooltip warning (#530) * refactor #504 textView (#547) * hotfix REACT_APP_SHOW_ONLY_OPER_CARDS (#556) * location map - tooltip location is misplaced (#555) * Refactor 490 remove text at road (#566) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file Co-authored-by: Yael Luria <[email protected]> * Refactor 491 textview add road on top left (#565) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * fix redundant components and interfaces * added additional fixes * change widget header variant * fix merge issues Co-authored-by: Yael Luria <[email protected]> * [Feat-526] add social share buttons (#550) * install react-share and create SocialShare Atom * Add SocialShare below Cards * convert styling to use Box * [Feat-489] Show description on show more (#546) * show description on show more (#489) * show description on show more only on title and description mismatch (#489) * show only description on show more (#489) * add border to table closes #557 (#570) * hotfix injured_count_per_age_group * hotfix InjuredCountPerAgeGroupPieWidget * Refactor 490 remove text at road (#569) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * fixes following review Co-authored-by: Yael Luria <[email protected]> * implement widget injured accidents with pedestrian (#563) * implement widget injured accidents with pedestrian * add legend & refactor per comments * [Refactor-411] update packages (#578) * npm update and fix ts errors * change ts fixing implementation * Refactor 495 pixel perfect design (#571) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review Co-authored-by: Yael Luria <[email protected]> * [Fix-553] Head on collision design review (#567) * background image margin (#553) * pie chart shadow (#553) * card content alignment (#553) * adjust shadow (#553) * CR * CR (#553) * center label for single slice (#553) * lint (#553) * use theme spacing Co-authored-by: yuvalbl <[email protected]> * update operational widgets list (#581) * v0.2.0 * hotfix getOperWidgetData * Update Release.md * Ms3 minor issues (#591) * minor card fixes * table minor fixes * fix i18n * [Refactor/BUG] remove default mock data (#599) * Refactor fix review comments on pr 571 (#580) * extract severity image to seperate component, add functionality to find single type and display severity image for that type, closes #447 * refactor #504 textView * added regexp to cut road prefix * added regexp * removed redundant textview file * get segment text from different field and removed regexp implementation * pixel perfect * pixel perfect additional work * added compatibility with single type case * adjust positions and additional colors * changes following review * refactoring after review Co-authored-by: Yael Luria <[email protected]> * [refactor-572] - replace meta tag content (#610) Replace meta tag content. * move text outside the chart (#615) * remove cors error and update auth serer urls in env files (#612) * Feat 558 header center break titles (#598) * break long title in header center variant closes #558 * 595-bug-refactor availability num of severity type (#614) * feat-561-implement-localization-api (#625) * add support for localization api * remove comment * [feat-552] Add label to header varient (#623) * [feat-552] Add label to header varient * [feat-552] fix code after code review * [feat-552] add opacity * [feat-552] refactor style * fix header text view (#624) * bug 628 card header have duplicate variables (#629) * fix card heder duplicates * fix unused import * 592- refactor -pie conditional label on '0' value (#613) Co-authored-by: danielsh28 <[email protected]> Co-authored-by: SejoB <[email protected]> Co-authored-by: Eyal Levi <[email protected]> Co-authored-by: Adele Angel <[email protected]> Co-authored-by: sejoB <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yoav Porat <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Idan Levian <[email protected]> * v0.4.0 (#661) * Feat 530 add tooltip to information button (#626) * [feat-530] add type to meta.information interface * [feat-530] hand over to AnyWayCard component information props * [feat-530] hand over to AnyWayCard component information props * [feat-530] add information to tooltip * [feat-530] fix by CR comment * [feat-530] replace px with theme.spacing * CR fixes Co-authored-by: yuvalbl <[email protected]> * Fix-586-social icons outline (#639) * fixed social button outline * fix twitter icon outline * fixed class name * deleted redundent files that were added by mistake * Feat-467 user user registration screen (#619) * upload for draft pr * first success signed in display using email as identifier * add auth server url env var * added pop-up ridirect and button * added pop-up ridirect and button * initial flow of screen and user update * aded i18 and refactor update screen flow * basic flow for sign in * remove unnecessary query param * apply destructuring to form event * changes: logout api call added to user.service.ts destructuring for orm default values applied in Header.tsx applied another import was added * fix import to one liner * added fixes following review * [feat-643] add link to readme file (#644) * Feat 616 add bold to typography (#656) * [feat-616] add bold to typhography atom * [feat-616] remove bold in makeStyles and bold it from typography atom * [feat-616] use useStyles hook for the style * hide login button and icon (#660) * [refactor-637] change text literals to i-18 translate pipe (#642) * text literals changed to i-18 translate pipe * fixed text to represent meaning * resolved gh issues * centered label position on full sector (#641) * centered label position on full sector * fix single slice pie Co-authored-by: yuvalbl <[email protected]> * v0.4.0 Co-authored-by: Idan Levian <[email protected]> Co-authored-by: daniel-ilan <[email protected]> Co-authored-by: danielsh28 <[email protected]> Co-authored-by: SejoB <[email protected]> * v.0.8.0 (#735) * Bug 683 fix login issues (#690) * added form tag and submit prop to button * added validations * change reidirect method and setting env files, change error display issue on form * fix location, env vars, button props * fix location Co-authored-by: almogbhl <[email protected]> * Hotfix fix isprod flag (#702) * hotfix fix isprod flag * fix login hide * feat-317-implement-get-verified-widgets-data (#691) * veriefied widgets data * requested changes * vertically aligned user icon (#703) * refactor-700-update-mobx-packages (#707) * update packages * updated mobx * requested changes * [Feat-699]-Change-site-and-graphics-font-to-Rubik (#712) * change site and graphics font to rubik * rm alef font from index and from _fonts.ts files * fix react-leaflet core issue (#716) * remove-font-style (#718) * Hotfix add staging env flag (#720) * remove-font-style * hotfix add staging env flags * hotfix login postmessage (#722) * Add overflow property to hide scrollbars (#713) * adding missing key to elements array in AccidentsOccurred (#723) * Transfer the PopUpRedirect file to the Atom folder (#728) Co-authored-by: danielsh28 <[email protected]> Co-authored-by: almogbhl <[email protected]> Co-authored-by: SejoB <[email protected]> Co-authored-by: Daniel Ilan <[email protected]> Co-authored-by: IsaacM890 <[email protected]> Co-authored-by: MashaPav <[email protected]> Co-authored-by: YaronAvraham93 <[email protected]> * v0.8.0 * fix lint issue * feat-724 added admin services and coressponding interfaces * SBT-2297 first ui component adding * v0.12.0 (#840) * fix-773 changed fontWeight to 400 and added empty object check in use… (#775) * fix-773 changed fontWeight to 400 and added empty object check in useBold function * fix-773 fixed destructuring Typography prop bold * fix-773 reformatted with prettier linter * fix-773 fixed useBold to use default parameter instead of type * refactor-773 made location title bold * [Feat-759] Add version number to Footer (#807) * Update ci.yml * Update ci.yml * v0.10.1 (#811) * v0.10.0 * v0.10.1 * improve firebase files * Update ci.yml * Update ci.yml * doc update readme (#813) * [Refactor-776] Move language strings to const file (#808) * [Refactor-776] Move language strings to const file * [Refactor-776] Use enum instead of consts * followed instruction to complete issue (#814) * Update ci.yml * [doc] code guidleines (#825) * styles * docs * [Feat-776] change lint script (#831) * change lint script * add no-restricted-imports rule to avoid relative imports * add no-multiple-empty-lines error * fixed according to npm run lint suggestions Co-authored-by: harduf <[email protected]> * Fixed showing 0 when there's no fatal/severe/light accidents (#828) * changing env file so demo card isn't shown (#822) * Feat 803 bring back last update in the bottom of the widgets --- new! (#838) * did npm i * inital commit * Update CardFooter.tsx * [774] Adapt to new news-flash API (#839) interurban_only and road_segment query parameters are deprecated. a new query param is introduced: resolution. currently requesting only suburban_road resolution (same as interurban). later commits should add street resolution (per BE readiness). * Bump axios from 0.21.1 to 0.21.2 (#812) Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Bug 823] missing word mikta inside accident (#826) * it works, but maybe not best practice * fixing dictionary, removing console logs * removed extra space * v0.12.0 Co-authored-by: Chen Mualem <[email protected]> Co-authored-by: segevda <[email protected]> Co-authored-by: Harduf-l <[email protected]> Co-authored-by: harduf <[email protected]> Co-authored-by: noa-ui <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * delete redundaunt file * delete file * feat-724 added getter for table data (#836) * feat-724 added getter for table data * add organizations api * Merge branch 'master' into feat-724-user-management-services # Conflicts: # package-lock.json # package.json # src/components/molecules/TextView/TextViewHeader.tsx # src/components/molecules/UserProfileHeader.tsx # src/components/organisms/Footer.tsx # src/store/root.store.ts * addded org service * remove ci failed issue * adding setOrg to store * adding remove user func * Merge branch 'feat-724-add-admin-services' into feat-724-user-management-services # Conflicts: # src/components/molecules/TextView/TextViewHeader.tsx # src/components/molecules/UserProfileHeader.tsx * Feat 724 add admin services (#837) * very inital chart * table with mock data * removing uncessary variable * replacing with 'isAdmin' again * added words to dictionary * current state * getting real data works now * removed unused variable * saving changes * removing not needed useEffect * added loader, interaction with backend works * fixing loading timing * fixed according to comments * fixing names, organizing in folders * taking care of changes * adjust row height and dialog width * fixed row and cell size Co-authored-by: danielsh28 <[email protected]> * delete unneccessry files * remove spaces Co-authored-by: Yuval <[email protected]> Co-authored-by: SejoB <[email protected]> Co-authored-by: Eyal Levi <[email protected]> Co-authored-by: Adele Angel <[email protected]> Co-authored-by: sejoB <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: Almog Langleben <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yoav Porat <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Yael Luria <[email protected]> Co-authored-by: Idan Levian <[email protected]> Co-authored-by: yuvalbl <[email protected]> Co-authored-by: daniel-ilan <[email protected]> Co-authored-by: almogbhl <[email protected]> Co-authored-by: IsaacM890 <[email protected]> Co-authored-by: MashaPav <[email protected]> Co-authored-by: YaronAvraham93 <[email protected]> Co-authored-by: Chen Mualem <[email protected]> Co-authored-by: segevda <[email protected]> Co-authored-by: Harduf-l <[email protected]> Co-authored-by: harduf <[email protected]> Co-authored-by: noa-ui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textView molecule >> const extractCount >>change checking availability of one or more types instead of Two