Skip to content

feat(base): allow exceeded memory limit if no workload #17785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Apr 16, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(base): allow exceeded memory limit if no workload

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 16, 2025
@zhang2014
Copy link
Member Author

Memory Management Test Summary

Test Configuration:

  • max_server_memory_usage = 1GB
  • max_query_memory_usage = 400MB
  • query_out_of_memory_behavior = 'throw'
  • 3 concurrent queries executing:
    SELECT number::string FROM numbers(10000000) GROUP BY number::string; -- ~480MB/query

Results Comparison:

Main Branch This PR
Outcome All 3 queries → Soft OOM 1 Soft OOM + 2 Successes

@zhang2014 zhang2014 marked this pull request as ready for review April 20, 2025 06:13
@zhang2014 zhang2014 requested a review from BohuTANG April 20, 2025 06:13
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Apr 20, 2025
Copy link
Contributor

Docker Image for PR

  • tag: pr-17785-5f6f91c-1745132821

note: this image tag is only available for internal use.

@zhang2014 zhang2014 marked this pull request as draft April 20, 2025 07:15
# Conflicts:
#	src/query/service/src/servers/http/middleware/session.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant