Skip to content

Conversation

@drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

[metasrv] refactor: simplify metasrv cluster starting up in tests.

Changelog

  • Improvement

Related Issues

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/A2MePwf3NttVDnpgCWAAqVLpzAH8
✅ Preview: Canceled

@drmingdrmer drmingdrmer marked this pull request as ready for review December 10, 2021 15:17
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// Bring upa cluster of metasrv, the first one is the leader.
///
/// It returns a vec of test-context.
pub async fn start_metasrv_cluster(node_ids: &[NodeId]) -> anyhow::Result<Vec<MetaSrvTestContext>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice shot!

@databend-bot
Copy link
Member

Wait for another reviewer approval

@drmingdrmer drmingdrmer merged commit 72b2f40 into databendlabs:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants