Remove redundant include stanza from dashboard acceptance tests #3077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
requested review from
andrewnester,
shreyas-goenka,
denik and
anton-107
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant include stanzas from the sync configuration in dashboard acceptance test templates, as they are unrelated to dashboards.
- Removed unnecessary
includesection undersyncin two template files. - Simplifies sync paths to only use
pathsdirective.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| acceptance/bundle/deploy/dashboard/simple_syncroot/databricks.yml.tmpl | Removed redundant include lines under sync |
| acceptance/bundle/deploy/dashboard/simple_outside_bundle_root/databricks.yml.tmpl | Removed redundant include lines under sync |
andrewnester
approved these changes
Jun 18, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
## Changes The includes for file synchronization are unrelated to dashboards. ## Why Thread in https://github.com/databricks/cli/pull/3006/files#r2140059656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The includes for file synchronization are unrelated to dashboards.
Why
Thread in https://github.com/databricks/cli/pull/3006/files#r2140059656