Make FromSlice and ToSlice methods private to the deploy package
#3089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
changed the title
deploy packagedeploy package
anton-107
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
anton-107
force-pushed
the
anton-107/state-private-methods
branch
from
4e3f2fa to
4193d84
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Keeping methods private to the package makes the code easier to comprehend - private methods are used only inside the package where they are defined
Tests
Existing tests