-
Notifications
You must be signed in to change notification settings - Fork 367
ENH: Add from_arrays for MultiIndex #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe here is the problem ?
|
|
hahaha, yeah, my bad. I didn't check carefully and then went to bed because i was too sleepy yesterday. @itholic |
|
haha. yeah that is also happening to me often. 😄 |
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 94.79% 94.79% +<.01%
==========================================
Files 34 34
Lines 6572 6575 +3
==========================================
+ Hits 6230 6233 +3
Misses 342 342
Continue to review full report at Codecov.
|
|
@charlesdong1991 Shall we keep the example in the first commit with |
|
oh, okay 😅 |
databricks/koalas/indexes.py
Outdated
| -------- | ||
| >>> arrays = [[1, 1, 2, 2], ['red', 'blue', 'red', 'blue']] | ||
| >>> ks..MultiIndex.from_arrays(arrays, names=('number', 'color')) # doctest: +SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, sorry, please fix ks.Multi. 😄
also nit: style. need 2 spaces before #.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, god, sorry 😅
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests.
Softagram Impact Report for pull/1001 (head commit: f5e6d3f)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Thanks! merging. |

I was trying to create a MultiIndex from an array just now, and found out it hadnt been implemented, so have this PR to create MI from arrays.