Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented Nov 7, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #1027 into master will decrease coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   94.92%   93.47%   -1.45%     
==========================================
  Files          34       34              
  Lines        6699     6699              
==========================================
- Hits         6359     6262      -97     
- Misses        340      437      +97
Impacted Files Coverage Δ
databricks/koalas/usage_logging/__init__.py 24.54% <0%> (-72.73%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 80.85% <0%> (-6.39%) ⬇️
databricks/conftest.py 94% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ee1b2...af7841e. Read the comment docs.

@ueshin ueshin changed the title Use print_function to show a proper error for Python 2. [WIP] Use print_function to show a proper error for Python 2. Nov 7, 2019
@ueshin ueshin changed the title [WIP] Use print_function to show a proper error for Python 2. Use print_function to show a proper error for Python 2. Nov 7, 2019
@softagram-bot
Copy link

Softagram Impact Report for pull/1027 (head commit: af7841e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@ueshin ueshin changed the title Use print_function to show a proper error for Python 2. setup.py should support Python 2 to show a proper error message. Nov 7, 2019
@ueshin
Copy link
Collaborator Author

ueshin commented Nov 8, 2019

Thanks! I'd merge this now.

@ueshin ueshin merged commit 935a02c into databricks:master Nov 8, 2019
@ueshin ueshin deleted the print_function branch November 8, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants