-
Notifications
You must be signed in to change notification settings - Fork 367
Add option_context. #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option_context. #1077
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
=========================================
- Coverage 95.2% 95.2% -0.01%
=========================================
Files 34 34
Lines 6868 6880 +12
=========================================
+ Hits 6539 6550 +11
- Misses 329 330 +1
Continue to review full report at Codecov.
|
| reset_option | ||
| get_option | ||
| set_option | ||
| option_context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should document at docs/source/user_guide/options.rst too. Seems pandas has it too (https://pandas.pydata.org/pandas-docs/stable/user_guide/options.html).
Maybe we can fix some instances at "Operations on different DataFrames" too .. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems one more instance in 10 mins too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add to 10 mins. It's an example for spark conf.
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise. +1
Softagram Impact Report for pull/1077 (head commit: 6d8f35b)⭐ Change Overview
⭐ Details of Dependency Changes
💡 Insights
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |


No description provided.