Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented Nov 26, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #1077 into master will decrease coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1077      +/-   ##
=========================================
- Coverage    95.2%   95.2%   -0.01%     
=========================================
  Files          34      34              
  Lines        6868    6880      +12     
=========================================
+ Hits         6539    6550      +11     
- Misses        329     330       +1
Impacted Files Coverage Δ
databricks/koalas/__init__.py 87.23% <ø> (ø) ⬆️
databricks/koalas/frame.py 96.74% <ø> (ø) ⬆️
databricks/koalas/config.py 98.98% <92.3%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e9ebe...6d8f35b. Read the comment docs.

reset_option
get_option
set_option
option_context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should document at docs/source/user_guide/options.rst too. Seems pandas has it too (https://pandas.pydata.org/pandas-docs/stable/user_guide/options.html).

Maybe we can fix some instances at "Operations on different DataFrames" too .. ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems one more instance in 10 mins too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add to 10 mins. It's an example for spark conf.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. +1

@softagram-bot
Copy link

Softagram Impact Report for pull/1077 (head commit: 6d8f35b)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

⭐ Details of Dependency Changes

details of dependency changes - click for full size
(Open in Softagram Desktop for full details)

💡 Insights

  • Co-change Alert: You modified test_frame_plot.py. Often plot.py (databricks/koalas) is modified at the same time.
  • Co-change Alert: You modified test_groupby.py. Often groupby.py (databricks/koalas) is modified at the same time.

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 2a5d836 into databricks:master Nov 27, 2019
@ueshin ueshin deleted the option_context branch November 27, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants