Skip to content

Conversation

@harupy
Copy link
Contributor

@harupy harupy commented Nov 28, 2019

As @ueshin pointed out in #1029 (comment), the fix #1029 didn't cover the case below. This PR fixes it.

>>> ks.options.compute.ops_on_diff_frames = True
>>> s1 = pd.Series([True, False, True], index=list("ABC"), name="x")
>>> s2 = pd.Series([True, True, False], index=list("ABD"), name="x")
>>> s1
A     True
B    False
C     True
Name: x, dtype: bool
>>> s2
A     True
B     True
D    False
Name: x, dtype: bool
>>> s1 | s2
A     True
B     True
C     True
D    False
Name: x, dtype: bool
>>> (ks.from_pandas(s1) | ks.from_pandas(s2)).sort_index()
A    True
B    True
C    True
D    None
Name: x, dtype: object

@softagram-bot
Copy link

Softagram Impact Report for pull/1083 (head commit: 0a63afe)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #1083 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1083      +/-   ##
=========================================
+ Coverage    95.2%   95.2%   +<.01%     
=========================================
  Files          34      34              
  Lines        6883    6886       +3     
=========================================
+ Hits         6553    6556       +3     
  Misses        330     330
Impacted Files Coverage Δ
databricks/koalas/base.py 95.4% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7170cb...0a63afe. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 84d8924 into databricks:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants