-
Notifications
You must be signed in to change notification settings - Fork 367
Complete NumPy ufunc compatibility in Series #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 95.19% 95.21% +0.01%
==========================================
Files 34 35 +1
Lines 6935 6953 +18
==========================================
+ Hits 6602 6620 +18
Misses 333 333
Continue to review full report at Codecov.
|
a2554df to
a4fd4df
Compare
f109a7c to
4d9a13e
Compare
1f8fc4a to
b59e233
Compare
Softagram Impact Report for pull/1106 (head commit: b59e233)
|
|
tests passed. |
| np.random.randint(-100, 100, size=(np.random.randint(100), 2)), columns=['a', 'b']) | ||
| kdf = ks.from_pandas(pdf) | ||
|
|
||
| blacklist = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, I ran it few hundreds times and it seems not flaky.
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks! merging. |

This PR completes NumPy's ufunc support (followup of #1096).
See also https://docs.scipy.org/doc/numpy/reference/arrays.classes.html#standard-array-subclasses
E.g.: