-
Notifications
You must be signed in to change notification settings - Fork 367
Add PyArrow 0.15 support back, and test PyArrow 0.16 in CI #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
+ Coverage 95.01% 95.05% +0.03%
==========================================
Files 34 34
Lines 7944 7962 +18
==========================================
+ Hits 7548 7568 +20
+ Misses 396 394 -2
Continue to review full report at Codecov.
|
2ec5dea to
c776eeb
Compare
3d75a00 to
3fde8bd
Compare
79b416b to
5c1b665
Compare
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
|
Thanks for detailed review @ueshin! |
7c4b533 to
4d0c17d
Compare
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks! merging. |
This PR adds PyArrow 0.15 support back with a better documentation and error message.
Error message will look as below:
Warning when pyarrow>=0.15 and pyspark<3.0 but
ARROW_PRE_0_15_IPC_FORMATnot set.Exceptions when
ARROW_PRE_0_15_IPC_FORMATis set in valid cases:Resolves #1109