Skip to content

Conversation

@RainFung
Copy link
Contributor

Implement Index.drop by using spark isin API

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #1117 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1117      +/-   ##
=========================================
+ Coverage   95.19%   95.2%   +<.01%     
=========================================
  Files          35      35              
  Lines        7075    7086      +11     
=========================================
+ Hits         6735    6746      +11     
  Misses        340     340
Impacted Files Coverage Δ
databricks/koalas/missing/indexes.py 100% <ø> (ø) ⬆️
databricks/koalas/indexes.py 96.61% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b569f...d58bedb. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/1117 (head commit: 0979130)

⚠️ Copy paste found

ℹ️ test_indexes.py: Copy paste fragment on line 30 shared with ../test_dataframe.py, ../test_numpy_compat.py:


    @property
    def pdf(self):
        return pd.DataFrame({
            'a': [1, 2, 3, 4, 5, 6, 7, 8, 9],
            'b': [4, 5, 6, 3, 2, 1, ...(truncated 160 chars)

ℹ️ indexes.py: Copy paste fragment inside the same file on lines 747, 1118:

            raise NotImplementedError(
                \"Doesn't support symmetric_difference between Index & MultiIndex for now\")

        sdf_self = self._kdf._s...(truncated 477 chars)

Now that you are on the file, it would be easier to pay back some tech. debt.

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 7f59f81 into databricks:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants