Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Dec 17, 2019

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.dot.html#pandas.Series.dot

>>> s = ks.Series([0, 1, 2, 3])
>>> other = ks.Series([-1, 2, -3, 4])

>>> s.dot(other)
8

>>> s @ other
8

>>> df = ks.DataFrame([[0, 1], [-2, 3], [4, -5], [6, 7]])
>>> s.dot(df)
0    24
1    14
Name: 0, dtype: int64

@softagram-bot
Copy link

Softagram Impact Report for pull/1136 (head commit: a65f1b6)

⚠️ Copy paste found

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment on line 601 shared with ../test_series.py:


        # for MultiIndex
        midx = pd.MultiIndex([['lama', 'cow', 'falcon'],
                              ['speed', 'weight', 'length']],
                             ...(truncated 201 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment on line 604 shared with ../test_series.py:

                              ['speed', 'weight', 'length']],
                             [[0, 0, 0, 1, 1, 1, 2, 2, 2],
                      ...(truncated 149 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment on line 601 shared with ../test_series.py:


        # for MultiIndex
        midx = pd.MultiIndex([['lama', 'cow', 'falcon'],
                              ['speed', 'weight', 'length']],
                             ...(truncated 169 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 541, 686:

                       repr(kdf1.where(kdf2 > 100).sort_index()))

        pdf1 = pd.DataFrame({'A': [-1, -2, -3, -4, -5], 'B': [-100, -200, -300, ...(truncated 174 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 558, 705:

                       repr(kdf1.mask(kdf2 < 100).sort_index()))

        pdf1 = pd.DataFrame({'A': [-1, -2, -3, -4, -5], 'B': [-100, -200, -300, -4...(truncated 172 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 549, 695:

                       repr(kdf1.where(kdf2 < -250).sort_index()))

    def test_mask(self):
        pdf1 = pd.DataFrame({'A': [0, 1, 2, 3, 4], 'B...(truncated 195 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 687, 706:


        pdf1 = pd.DataFrame({'A': [-1, -2, -3, -4, -5], 'B': [-100, -200, -300, -400, -500]})
        pdf2 = pd.DataFrame({'A': [...(truncated 275 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 542, 559:


        pdf1 = pd.DataFrame({'A': [-1, -2, -3, -4, -5], 'B': [-100, -200, -300, -400, -500]})
        pdf2 = pd.DataFrame({'A': [-10,...(truncated 176 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 679, 698:

        pdf1 = pd.DataFrame({'A': [0, 1, 2, 3, 4], 'B': [100, 200, 300, 400, 500]})
        pdf2 = pd.DataFrame({'A': [0, -1, -2, -3, -4], 'B': [-100, -200, -300, -400, -500]...(truncated 223 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 542, 706:


        pdf1 = pd.DataFrame({'A': [-1, -2, -3, -4, -5], 'B': [-100, -200, -300, -400, -500]})
        pdf2 = pd.DataFrame({'A': [-10,...(truncated 121 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 559, 687:


        pdf1 = pd.DataFrame({'A': [-1, -2, -3, -4, -5], 'B': [-100, -200, -300, -400, -500]})
        pdf2 = pd.DataFrame({'A': [-10, ...(truncated 120 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 535, 552:

        pdf1 = pd.DataFrame({'A': [0, 1, 2, 3, 4], 'B': [100, 200, 300, 400, 500]})
        pdf2 = pd.DataFrame({'A': [0, -1, -2, -3, -4], 'B': [-100, -200, -300, -400, -500]...(truncated 128 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 300, 535, 552:

        pdf1 = pd.DataFrame({'A': [0, 1, 2, 3, 4], 'B': [100, 200, 300, 400, 500]})
        pdf2 = pd.DataFrame({'A': [0, -1, -2, -3, -4], 'B': [-100, -200, ...(truncated 137 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 535, 679:

        pdf1 = pd.DataFrame({'A': [0, 1, 2, 3, 4], 'B': [100, 200, 300, 400, 500]})
        pdf2 = pd.DataFrame({'A': [0, -1, -2, -3, -4], 'B': [-100, -200, -300, -400, -500]...(truncated 74 chars)

ℹ️ test_ops_on_diff_frames.py: Copy paste fragment inside the same file on lines 300, 535, 552, 679, 698:

        pdf1 = pd.DataFrame({'A': [0, 1, 2, 3, 4], 'B': [100, 200, 300, 400, 500]})
        pdf2 = pd.DataFrame({'A': [0, -1, -2, -3, -4], 'B': [-100, -200, ...(truncated 91 chars)

Now that you are on the file, it would be easier to pay back some tech. debt.

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

💡 Insights

  • Co-change Alert: You modified series.py. Often frame.py (databricks/koalas) is modified at the same time.

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #1136 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage    95.2%   95.23%   +0.02%     
==========================================
  Files          34       34              
  Lines        7472     7495      +23     
==========================================
+ Hits         7114     7138      +24     
+ Misses        358      357       -1
Impacted Files Coverage Δ
databricks/koalas/missing/series.py 100% <ø> (ø) ⬆️
databricks/koalas/series.py 96.78% <100%> (+0.04%) ⬆️
databricks/koalas/utils.py 94.94% <0%> (ø) ⬆️
databricks/koalas/groupby.py 91.47% <0%> (+0.03%) ⬆️
databricks/koalas/generic.py 97.54% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbae324...a111505. Read the comment docs.

@itholic itholic changed the title Implement dot() for Series [WIP] Implement dot() for Series Dec 30, 2019
@HyukjinKwon
Copy link
Member

@itholic, can you rebase this PR? seems fine.

@itholic itholic changed the title [WIP] Implement dot() for Series Implement dot() for Series Mar 12, 2020
@itholic
Copy link
Contributor Author

itholic commented Mar 12, 2020

@HyukjinKwon Rebase & test finished :)

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@itholic
Copy link
Contributor Author

itholic commented Mar 13, 2020

@HyukjinKwon Thanks for the review, I fixed them :D

@HyukjinKwon HyukjinKwon merged commit db96f9d into databricks:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants