Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 20, 2019

No description provided.

@ueshin ueshin requested a review from HyukjinKwon December 20, 2019 22:57
@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #1151 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   95.12%   95.21%   +0.08%     
==========================================
  Files          35       35              
  Lines        7058     7064       +6     
==========================================
+ Hits         6714     6726      +12     
+ Misses        344      338       -6
Impacted Files Coverage Δ
databricks/koalas/groupby.py 91.6% <ø> (ø) ⬆️
databricks/koalas/missing/indexes.py 100% <ø> (ø) ⬆️
databricks/koalas/indexes.py 96.75% <100%> (+0.08%) ⬆️
databricks/koalas/frame.py 97.01% <0%> (+0.11%) ⬆️
databricks/koalas/plot.py 94.28% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17cad7f...c33119a. Read the comment docs.

@ueshin ueshin changed the title [WIP] Randomize index in tests. Randomize index in tests. Dec 26, 2019
@ueshin ueshin changed the title Randomize index in tests. [WIP] Randomize index in tests. Dec 26, 2019
@ueshin ueshin changed the title [WIP] Randomize index in tests. Randomize index in tests and fix some window-like functions. Jan 1, 2020
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't taken a close look but seems fine.

@ueshin
Copy link
Collaborator Author

ueshin commented Jan 6, 2020

Thanks! I'd merge this now. Please feel free to leave comments if you have any.

@ueshin ueshin merged commit 3636b3b into databricks:master Jan 6, 2020
@ueshin ueshin deleted the random_index branch January 6, 2020 19:04
ryantqiu pushed a commit to snorkel-marlin-repos/databricks_koalas_pr_1151_d19e5653-70e2-453d-8d7c-d74ec1e3d5f8 that referenced this pull request Oct 1, 2025
ryantqiu added a commit to snorkel-marlin-repos/databricks_koalas_pr_1151_d19e5653-70e2-453d-8d7c-d74ec1e3d5f8 that referenced this pull request Oct 1, 2025
ryantqiu pushed a commit to snorkel-marlin-repos/databricks_koalas_pr_1151_7fe19a16-f195-4886-813a-3c14dfe7d913 that referenced this pull request Oct 2, 2025
ryantqiu added a commit to snorkel-marlin-repos/databricks_koalas_pr_1151_7fe19a16-f195-4886-813a-3c14dfe7d913 that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants