Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented Jan 8, 2020

No description provided.

@ueshin ueshin requested a review from HyukjinKwon January 8, 2020 22:26
@softagram-bot
Copy link

Softagram Impact Report for pull/1177 (head commit: 301135c)

⚠️ Copy paste found

ℹ️ frame.py: Copy paste fragment on line 5753 shared with ../namespace.py:

              on: Union[str, List[str], Tuple[str, ...], List[Tuple[str, ...]]] = None,
              left_on: Union[str, List[str], Tuple[s...(truncated 273 chars)

ℹ️ frame.py: Copy paste fragment inside the same file on lines 7255, 7338:


        # TODO: there is a similar logic to transpose in, for instance,
        #  DataFrame.any, Series.quantile. Maybe ...(truncated 1065 chars)

ℹ️ frame.py: Copy paste fragment inside the same file on lines 4914, 4936:

            sdf = self._sdf.select(
                self._internal.index_scols +
                [self._internal.scol_for(idx...(truncated 505 chars)

Now that you are on the file, it would be easier to pay back some tech. debt.

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

💡 Insights

  • Co-change Alert: You modified frame.py. Often series.py (databricks/koalas) is modified at the same time.

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@ueshin
Copy link
Collaborator Author

ueshin commented Jan 8, 2020

I'd merge this now.

@ueshin ueshin merged commit a3acb81 into databricks:master Jan 8, 2020
@ueshin ueshin deleted the repr_html branch January 8, 2020 23:07
@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #1177 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files          35       35           
  Lines        7084     7084           
=======================================
  Hits         6750     6750           
  Misses        334      334
Impacted Files Coverage Δ
databricks/koalas/frame.py 97.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c2214...301135c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants