-
Notifications
You must be signed in to change notification settings - Fork 367
Add Index.to_frame. #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Index.to_frame. #1187
Conversation
| # FIXME: the index values are not addressed the change. (#1190) | ||
| # self.assert_eq((kidx + 1).to_series(), (pidx + 1).to_series()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #1190.
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 95.24% 95.21% -0.03%
==========================================
Files 35 35
Lines 7105 7132 +27
==========================================
+ Hits 6767 6791 +24
- Misses 338 341 +3
Continue to review full report at Codecov.
|
Softagram Impact Report for pull/1187 (head commit: 90b2aad)
|
| index_map = [(name_like_string(idx), n) | ||
| for idx, n in zip(name, self._internal.index_names)] | ||
| else: | ||
| index_map = None # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not pretty sure,
but how about index_map = [(SPARK_INDEX_NAME_FORMAT(0), None)]??
then maybe can we avoid attach_default_index ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the SPARK_INDEX_NAME_FORMAT(0) like here then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, i was mistaken. sorry for the confusion. 😞
(i thought sdf already has index column, so we could rename it to __index_level_0__ using alias and make index_map as [('index_level_0', None)] explicitly, but it was my mistaken)

No description provided.