Fix _InternalFrame.with_new_columns not to rename columns.
#1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
==========================================
+ Coverage 93.85% 95.27% +1.42%
==========================================
Files 35 35
Lines 7271 7393 +122
==========================================
+ Hits 6824 7044 +220
+ Misses 447 349 -98
Continue to review full report at Codecov.
|
HyukjinKwon
approved these changes
Jan 28, 2020
| self._groupkeys_scols = [F.col(name_like_string(s.name)) for s in self._groupkeys] | ||
| self._agg_columns_scols = [F.col(name_like_string(s.name)) for s in self._agg_columns] | ||
| self._groupkeys_scols = [F.col(s._internal.data_columns[0]) for s in self._groupkeys] | ||
| self._agg_columns_scols = [F.col(s._internal.data_columns[0]) for s in self._agg_columns] |
Member
There was a problem hiding this comment.
I think now we can enable the tests back (#1224 (comment)). I will make a small followup.
rising-star92
added a commit
to rising-star92/databricks-koalas
that referenced
this pull request
Jan 27, 2023
…different values (#1233) A small followup of databricks/koalas#1224 and databricks/koalas#1229 Now, we can cover this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not have renamed the columns in
_InternalFrame.with_new_columns, otherwise the new column names could be unexpectable.