-
Notifications
You must be signed in to change notification settings - Fork 367
Fix output of print() matches with pandas of Series #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
=========================================
+ Coverage 95.09% 95.1% +0.01%
=========================================
Files 35 35
Lines 7154 7152 -2
=========================================
- Hits 6803 6802 -1
+ Misses 351 350 -1
Continue to review full report at Codecov.
|
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Actually I don't remember why we use the string.
@HyukjinKwon do you know the reason?
|
LGTM, too if there is no proper reason we should use the existing behavior. |
|
nit: we better avoid |
Thanks for the good tip :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine given that it's consistent with DataFrame. I don't know if there's the particular reason either.
One concern might be it triggers an actual job when, for instance, the string representation is expected in an error message .. but I suspect it's fine for now.
Resolve #1248
Since the Python interpreter calls __repr__ if __str__ is not implemented,
the output will be identical to pandas using the implemented __repr__ of series.py.