-
Notifications
You must be signed in to change notification settings - Fork 367
Implement DataFrame.take #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataFrame.take #1292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
==========================================
- Coverage 95.23% 93.02% -2.21%
==========================================
Files 34 34
Lines 7576 7617 +41
==========================================
- Hits 7215 7086 -129
- Misses 361 531 +170
Continue to review full report at Codecov.
|
|
We have to find another solution since While i'm here, i'm searching and fixing the existing implementations. |
|
Seems like we can just delegate to |
|
@ueshin Ah, I should have took a look at more carefully. Thanks for the comment :) |
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
|
Could you update the PR description? |
|
@ueshin Yup, I just removed unmatched descriptions |
|
Thanks! merging. |
This PR proposes Implement of DataFrame.take