Skip to content

Conversation

@HyukjinKwon
Copy link
Member

This PR proposes to let extra options have higher priority to allow workarounds.

For instance, after this PR, you can disable schema inference:

>>> import databricks.koalas as ks
>>> ks.read_csv("tmp.csv").dtypes
a    int32
b    int32
c    int32
dtype: object
>>> ks.read_csv("tmp.csv", inferSchema=False).dtypes
a    object
b    object
c    object

@HyukjinKwon HyukjinKwon requested a review from ueshin February 20, 2020 04:22
@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #1296 into master will decrease coverage by 1.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1296     +/-   ##
=========================================
- Coverage   95.16%   93.77%   -1.4%     
=========================================
  Files          34       34             
  Lines        7265     7272      +7     
=========================================
- Hits         6914     6819     -95     
- Misses        351      453    +102
Impacted Files Coverage Δ
databricks/koalas/namespace.py 87.87% <100%> (ø) ⬆️
databricks/koalas/usage_logging/__init__.py 24.32% <0%> (-72.98%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 78.72% <0%> (-14.9%) ⬇️
databricks/conftest.py 92.45% <0%> (-3.78%) ⬇️
databricks/koalas/groupby.py 91.43% <0%> (ø) ⬆️
databricks/koalas/frame.py 96.51% <0%> (ø) ⬆️
databricks/koalas/internal.py 96.07% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c5a22...3d515e3. Read the comment docs.

@HyukjinKwon
Copy link
Member Author

@ueshin, let me merge this. Trivial and I am pretty sure :-).

@HyukjinKwon HyukjinKwon merged commit 7356ca4 into databricks:master Feb 24, 2020
HyukjinKwon added a commit that referenced this pull request Feb 24, 2020
The PR was synced after Black integration and the tests passed at #1296. But looks there was a sync'ing problem.
@HyukjinKwon HyukjinKwon deleted the read_csv branch September 11, 2020 07:52
rising-star92 added a commit to rising-star92/databricks-koalas that referenced this pull request Jan 27, 2023
The PR was synced after Black integration and the tests passed at databricks/koalas#1296. But looks there was a sync'ing problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants