Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 21, 2020

This PR proposes to add Black into Koalas.

Resolve #755

@HyukjinKwon HyukjinKwon force-pushed the add-black-fix branch 3 times, most recently from f9920c4 to 89a7a5c Compare February 21, 2020 08:15
@HyukjinKwon HyukjinKwon requested a review from ueshin February 21, 2020 08:16
@HyukjinKwon HyukjinKwon changed the title [WIP] Standardize code style using Black Standardize code style using Black Feb 21, 2020
@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #1301 into master will decrease coverage by 0.02%.
The diff coverage is 93.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
- Coverage   95.06%   95.04%   -0.03%     
==========================================
  Files          34       34              
  Lines        7233     7238       +5     
==========================================
+ Hits         6876     6879       +3     
- Misses        357      359       +2
Impacted Files Coverage Δ
databricks/koalas/missing/common.py 100% <ø> (ø) ⬆️
databricks/koalas/frame.py 96.51% <ø> (+0.05%) ⬆️
databricks/conftest.py 96.22% <100%> (+1.88%) ⬆️
databricks/koalas/numpy_compat.py 90.9% <100%> (ø) ⬆️
databricks/koalas/missing/frame.py 100% <100%> (ø) ⬆️
databricks/koalas/usage_logging/usage_logger.py 100% <100%> (ø) ⬆️
databricks/koalas/missing/__init__.py 100% <100%> (ø) ⬆️
databricks/koalas/mlflow.py 94.87% <100%> (ø) ⬆️
databricks/koalas/missing/groupby.py 100% <100%> (ø) ⬆️
databricks/koalas/usage_logging/__init__.py 98.19% <100%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b60d2...27cd200. Read the comment docs.

@HyukjinKwon
Copy link
Member Author

cc @ueshin and @itholic

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HyukjinKwon
Copy link
Member Author

I manually pushed to keep the co-author - 30b3334

Let's see if it's really useful ...

@itholic
Copy link
Contributor

itholic commented Feb 22, 2020

nice!

@HyukjinKwon HyukjinKwon deleted the add-black-fix branch September 11, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add precommit in workflow to standardize code style

5 participants