Return a Koalas series instead of pandas' in stats APIs at Koalas DataFrame #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Mar 10, 2020
| @unittest.skip( | ||
| "PySpark does not allow object type. " | ||
| "Should we support these case by casting to string? or just disallow?" | ||
| ) |
Member
Author
There was a problem hiding this comment.
I will make a followup after this PR.
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
+ Coverage 95.2% 95.26% +0.05%
==========================================
Files 34 34
Lines 7445 7448 +3
==========================================
+ Hits 7088 7095 +7
+ Misses 357 353 -4
Continue to review full report at Codecov.
|
ueshin
reviewed
Mar 11, 2020
HyukjinKwon
force-pushed
the
return_series_stats
branch
from
9d9f577 to
ce8e26b
Compare
HyukjinKwon
force-pushed
the
return_series_stats
branch
from
ce8e26b to
0bcf606
Compare
Member
Author
|
I discussed offline with @ueshin. I am going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Koalas' statics functions such as count, sum, min, max, etc. returns a pandas Series.
Resolves #1332