Add column axis in ks.concat #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
concat-axis=1
branch
2 times, most recently
from
c8b73b2 to
4fc4f38
Compare
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
- Coverage 95.23% 95.09% -0.14%
==========================================
Files 34 34
Lines 7576 7998 +422
==========================================
+ Hits 7215 7606 +391
- Misses 361 392 +31
Continue to review full report at Codecov.
|
itholic
reviewed
Mar 18, 2020
HyukjinKwon
force-pushed
the
concat-axis=1
branch
4 times, most recently
from
b1d0547 to
97a7718
Compare
ueshin
reviewed
Mar 20, 2020
HyukjinKwon
force-pushed
the
concat-axis=1
branch
2 times, most recently
from
cfd51ee to
0ef9bad
Compare
HyukjinKwon
force-pushed
the
concat-axis=1
branch
from
0ef9bad to
bb61faa
Compare
Member
Author
|
In the last commits, I addressed some corner cases such as operations against single column index vs multi-column index, and fixed some nits. |
HyukjinKwon
commented
Mar 20, 2020
| ( | ||
| [kdf3[("X", "A")].rename("ABC"), kdf3[("X", "B")]], | ||
| [pdf3[("X", "A")].rename("ABC"), pdf3[("X", "B")]], | ||
| ), |
Member
Author
There was a problem hiding this comment.
This two test cases were added to verify single index vs multi-index in the column.
HyukjinKwon
commented
Mar 20, 2020
| ValueError, | ||
| r"Labels have to be unique; however, got duplicated labels \['A'\].", | ||
| lambda: ks.concat([kdf.A, kdf4.A], join="inner", axis=1), | ||
| ) |
Member
Author
There was a problem hiding this comment.
This test also was added to verify duplicated column cases.
HyukjinKwon
force-pushed
the
concat-axis=1
branch
2 times, most recently
from
d18c4a2 to
64e9d7f
Compare
HyukjinKwon
commented
Mar 20, 2020
| pdf5 = pd.DataFrame({"A": [0, 2, 4], "B": [1, 3, 5]}, index=[1, 2, 3]) | ||
| pdf6 = pd.DataFrame({"C": [1, 2, 3]}, index=[1, 3, 5]) | ||
| kdf5 = ks.from_pandas(pdf5) | ||
| kdf6 = ks.from_pandas(pdf6) |
Member
Author
There was a problem hiding this comment.
Added another test case.
HyukjinKwon
force-pushed
the
concat-axis=1
branch
from
64e9d7f to
184fdc0
Compare
Member
Author
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add
axisatks.concat(...).Resolves #625, Closes #1009.