Skip to content

Fix get dummies when uses the prefix parameter whose type is dict #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2020
Merged

Fix get dummies when uses the prefix parameter whose type is dict #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf19f03
Fix get_dummies when prefix as a dict
itholic May 11, 2020
a0d44ea
Add test
itholic May 11, 2020
d3bbcfe
Fix to key-value matching
itholic May 11, 2020
c0eee47
Add test
itholic May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions databricks/koalas/namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,6 +1576,8 @@ def get_dummies(
"Length of 'prefix' ({}) did not match the length of "
"the columns being encoded ({}).".format(len(prefix), len(column_labels))
)
elif isinstance(prefix, dict):
prefix = [prefix[column_label[0]] for column_label in column_labels]

all_values = _reduce_spark_multi(
kdf._sdf, [F.collect_set(kdf._internal.spark_column_for(label)) for label in column_labels]
Expand Down
18 changes: 18 additions & 0 deletions databricks/koalas/tests/test_reshape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,24 @@ def test_get_dummies_prefix(self):
almost=True,
)

self.assert_eq(
ks.get_dummies(kdf, prefix={"A": "foo", "B": "bar"}),
pd.get_dummies(pdf, prefix={"A": "foo", "B": "bar"}),
almost=True,
)

self.assert_eq(
ks.get_dummies(kdf, prefix={"B": "foo", "A": "bar"}),
pd.get_dummies(pdf, prefix={"B": "foo", "A": "bar"}),
almost=True,
)

self.assert_eq(
ks.get_dummies(kdf, prefix={"A": "foo", "B": "bar"}, columns=["A", "B"]),
pd.get_dummies(pdf, prefix={"A": "foo", "B": "bar"}, columns=["A", "B"]),
almost=True,
)

with self.assertRaisesRegex(NotImplementedError, "string types"):
ks.get_dummies(kdf, prefix="foo")
with self.assertRaisesRegex(ValueError, "Length of 'prefix' \\(1\\) .* \\(2\\)"):
Expand Down