Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented May 21, 2020

Currently Series.clip creates a new DataFrame, so assigning back to the anchor DataFrame can't be executed without the option "compute.ops_on_diff_frames":

>>> kdf = ks.DataFrame({"a": [1, 2, 6, 4, 4, 6, 4, 3, 7]})
>>> kdf['clip'] = kdf.a.clip(3, 6)
Traceback (most recent call last):
...
ValueError: Cannot combine the series or dataframe because it comes from a different dataframe. In order to allow this operation, enable 'compute.ops_on_diff_frames' option.

@ueshin ueshin requested a review from HyukjinKwon May 21, 2020 22:28
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #1525 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1525   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files          36       36           
  Lines        8479     8480    +1     
=======================================
+ Hits         7972     7973    +1     
  Misses        507      507           
Impacted Files Coverage Δ
databricks/koalas/frame.py 95.56% <100.00%> (-0.03%) ⬇️
databricks/koalas/series.py 97.74% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f004ce...368eda0. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 421b80d into databricks:master May 22, 2020
@ueshin ueshin deleted the clip branch May 22, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants