Remove the deprecated pandas_wraps #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
May 22, 2020
| return "UnknownType[{}]".format(self.tpe) | ||
|
|
||
|
|
||
| def _to_stype(tpe) -> typing.Union[SeriesType, DataFrameType, ScalarType, UnknownType]: |
Member
Author
There was a problem hiding this comment.
Moved to infer_return_type as is.
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
==========================================
+ Coverage 93.97% 94.13% +0.16%
==========================================
Files 36 36
Lines 8500 8409 -91
==========================================
- Hits 7988 7916 -72
+ Misses 512 493 -19
Continue to review full report at Codecov.
|
Collaborator
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to remote
pandas_wrapsas it's deprecated.There are two more deprecated functions,
map_in_pandas, andget_dtype_counts. The former is referred more publicity for example in https://databricks.com/blog/2020/03/31/10-minutes-from-pandas-to-koalas-on-apache-spark.html. I would like to delay the removal.The latter is used in
DataFrame.infointernally when pandas < 1.0.0 is used. We can remove it when we use minimum pandas version as 1.0.0.