-
Notifications
You must be signed in to change notification settings - Fork 367
Add DataFrame.spark.apply #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| with self.assertRaisesRegex( | ||
| ValueError, "The output of the function.* pyspark.sql.DataFrame.*int" | ||
| ): | ||
| ks.range(10).spark.apply(lambda scol: 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move relevant test cases into here in a separate PR, e.g.) print_schema is in test_dataframe.py.
34de62e to
3e2ee2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 37 37
Lines 8487 8493 +6
=======================================
+ Hits 7990 7996 +6
Misses 497 497
Continue to review full report at Codecov.
|
| Returns | ||
| ------- | ||
| DataFrame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my opinion, how about Koalas DataFrame or ks.DataFrame rather just DataFrame because we're describing this functions as "Applies a function that takes and returns a Spark DataFrame" ??
I think maybe It can be confused whether the return type is Spark DataFrame or Koalas DataFrame.
|
LGTM, otherwise. |
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks! merging. |
This PR adds
DataFrame.spark.apply: