Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented Jun 10, 2020

Series.fillna should handle NaN properly.

>>> kser = ks.Series([1, 2, 3, 4, 5, 6], name="x")
>>> kser.loc[0] = np.nan
>>> kser
0    NaN
1    2.0
2    3.0
3    4.0
4    5.0
5    6.0
Name: x, dtype: float64
>>> kser.fillna(0)
0    NaN
1    2.0
2    3.0
3    4.0
4    5.0
5    6.0
Name: x, dtype: float64

This should be:

>>> kser.fillna(0)
0    0.0
1    2.0
2    3.0
3    4.0
4    5.0
5    6.0
Name: x, dtype: float64

@ueshin ueshin requested a review from HyukjinKwon June 10, 2020 22:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #1572 into master will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1572   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          38       38           
  Lines        8760     8763    +3     
=======================================
+ Hits         8282     8285    +3     
  Misses        478      478           
Impacted Files Coverage Δ
databricks/koalas/series.py 97.58% <88.88%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8c0d6...d735263. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 78af5cf into databricks:master Jun 11, 2020
@ueshin ueshin deleted the fillna branch June 11, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants