Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Jun 15, 2020

This PR propses Series.bfill and Series.ffill integrating with DataFrame.bfill and DataFrame.ffill to the generic.py

>>> kser = ks.Series([np.nan, 2, 3, 4, np.nan, 6], name="x")
>>> kser
0    NaN
1    2.0
2    3.0
3    4.0
4    NaN
5    6.0
Name: x, dtype: float64

>>> kser.bfill()
0    2.0
1    2.0
2    3.0
3    4.0
4    6.0
5    6.0
Name: x, dtype: float64

>>> kser.ffill()
0    NaN
1    2.0
2    3.0
3    4.0
4    4.0
5    6.0
Name: x, dtype: float64

@itholic itholic changed the title Adding Series.bfill Adding Series.bfill and Series.ffill Jun 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1580 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
- Coverage   94.55%   94.55%   -0.01%     
==========================================
  Files          38       38              
  Lines        8767     8765       -2     
==========================================
- Hits         8290     8288       -2     
  Misses        477      477              
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.81% <ø> (-0.01%) ⬇️
databricks/koalas/missing/series.py 100.00% <ø> (ø)
databricks/koalas/generic.py 96.71% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc27c2a...1771ba8. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Jun 15, 2020

Thanks! merging.

@ueshin ueshin merged commit ec63777 into databricks:master Jun 15, 2020
@itholic itholic deleted the f_bfill branch July 25, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants