Add sort parameter to concat. #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is based on #1627. Please review it first. |
ueshin
changed the title
HyukjinKwon
reviewed
Jul 9, 2020
| # We should return Series if objects are all Series. | ||
| should_return_series = all(map(lambda obj: isinstance(obj, Series), objs)) | ||
|
|
||
| # DataFrame, Series ... & Series, Series ... |
Member
There was a problem hiding this comment.
Maybe we should throw an exception when axis=1 and sort is set:
>>> import pandas as pd
>>> pd.concat([pd.DataFrame({'b': [4, 5, 6]}, index=[4,3,2]), pd.DataFrame({'a': [3, 4, 5]}, index=[4,3,2])], sort=False, axis=1)
b a
4 4 3
3 5 4
2 6 5
>>> pd.concat([pd.DataFrame({'b': [4, 5, 6]}, index=[4,3,2]), pd.DataFrame({'a': [3, 4, 5]}, index=[4,3,2])], sort=True, axis=1)
b a
2 6 5
3 5 4
4 4 3
Collaborator
Author
There was a problem hiding this comment.
Anyway pandas' behavior is not deterministic, at least seems so..
Member
There was a problem hiding this comment.
😭 .. any way is fine. We could just sort_index() or just throw an exception
HyukjinKwon
reviewed
Jul 9, 2020
databricks/koalas/namespace.py
Outdated
| merged_columns = sorted( | ||
| list(set(itertools.chain.from_iterable(column_labelses_of_kdfs))) | ||
| ) | ||
| merged_columns = column_labels_of_kdfs[0].copy() |
Member
There was a problem hiding this comment.
no big deal since it's already guarded above but we could add an assert for the length of column_labels_of_kdfs to be non-empty.
Member
There was a problem hiding this comment.
We could also add an assert on merged_columns too.
Collaborator
Author
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
sortparameter toks.concat().