Use pandas testing utils for exact cases. #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
commented
Aug 22, 2020
itholic
reviewed
Aug 23, 2020
itholic
reviewed
Aug 23, 2020
Contributor
|
Nice work! I'll revisit here after draft is finished |
Member
|
cc @itholic can you review this? |
itholic
reviewed
Aug 26, 2020
| self.assert_eq( | ||
| ks.get_dummies(kser, drop_first=True), | ||
| pd.get_dummies(pser, drop_first=True), | ||
| pd.get_dummies(pser, drop_first=True, dtype=np.int8), |
Contributor
There was a problem hiding this comment.
May we don't need dtype=np.int8 here if we still use almost=True below ?
itholic
reviewed
Aug 26, 2020
| self.assert_eq( | ||
| ks.get_dummies(kser, dummy_na=True), pd.get_dummies(pser, dummy_na=True), almost=True | ||
| ks.get_dummies(kser, dummy_na=True), | ||
| pd.get_dummies(pser, dummy_na=True, dtype=np.int8), |
itholic
approved these changes
Aug 26, 2020
Contributor
itholic
left a comment
itholic
left a comment
There was a problem hiding this comment.
Or it would be okay to leave it as it is, considering fixing it later.
| kdf = ks.from_pandas(pdf) | ||
|
|
||
| self.assert_eq(ks.get_dummies(kdf), pd.get_dummies(pdf), almost=True) | ||
| self.assert_eq(ks.get_dummies(kdf), pd.get_dummies(pdf, dtype=np.int8), almost=True) |
| self.assert_eq( | ||
| ks.get_dummies(kdf, columns=[("y", "c", "3"), ("x", "a", "1")]), | ||
| pd.get_dummies(pdf, columns=[("y", "c", "3"), ("x", "a", "1")]), | ||
| pd.get_dummies(pdf, columns=[("y", "c", "3"), ("x", "a", "1")], dtype=np.int8), |
| self.assert_eq( | ||
| ks.get_dummies(kdf, columns=["x"]), pd.get_dummies(pdf, columns=["x"]), almost=True | ||
| ks.get_dummies(kdf, columns=["x"]), | ||
| pd.get_dummies(pdf, columns=["x"], dtype=np.int8), |
| self.assert_eq( | ||
| ks.get_dummies(kdf, columns=("x", "a")), | ||
| pd.get_dummies(pdf, columns=("x", "a")), | ||
| pd.get_dummies(pdf, columns=("x", "a"), dtype=np.int8), |
| self.assert_eq( | ||
| ks.get_dummies(kdf, columns=["x"]), pd.get_dummies(pdf, columns=["x"]), almost=True | ||
| ks.get_dummies(kdf, columns=["x"]), | ||
| pd.get_dummies(pdf, columns=["x"], dtype=np.int8), |
Contributor
|
Otherwise, LGTM ! |
Collaborator
Author
|
For the |
Collaborator
Author
|
Thanks! I'd merge this now. Please feel free to leave comments if any. |
This was referenced Aug 30, 2020
ryantqiu
pushed a commit
to snorkel-marlin-repos/databricks_koalas_pr_1722_b82f507e-971c-4a9f-90c7-3ddce977c5bb
that referenced
this pull request
Oct 1, 2025
Original PR #1722 by ueshin Original: databricks/koalas#1722
ryantqiu
added a commit
to snorkel-marlin-repos/databricks_koalas_pr_1722_b82f507e-971c-4a9f-90c7-3ddce977c5bb
that referenced
this pull request
Oct 1, 2025
Merged from original PR #1722 Original: databricks/koalas#1722
ryantqiu
pushed a commit
to snorkel-marlin-repos/databricks_koalas_pr_1722_c0a015ec-4f22-4f4a-88eb-c818bb5ff630
that referenced
this pull request
Oct 2, 2025
Original PR #1722 by ueshin Original: databricks/koalas#1722
ryantqiu
added a commit
to snorkel-marlin-repos/databricks_koalas_pr_1722_c0a015ec-4f22-4f4a-88eb-c818bb5ff630
that referenced
this pull request
Oct 2, 2025
Merged from original PR #1722 Original: databricks/koalas#1722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the testing infrastructure for exact cases to pandas' testing library.