Skip to content

Exception handling for from_frame properly #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

Exception handling for from_frame properly #1791

merged 1 commit into from
Sep 23, 2020

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Sep 23, 2020

MultiIndex.from_frame doesn't raise exception properly when given parameter is not a DataFrame.

>>> pd.MultiIndex.from_frame(10)
Traceback (most recent call last):
...
TypeError: Input must be a DataFrame

>>> ks.MultiIndex.from_frame(10)
Traceback (most recent call last):
...
AttributeError: 'int' object has no attribute 'to_spark'

This PR fixed it and added related tests.

@itholic
Copy link
Contributor Author

itholic commented Sep 23, 2020

I'd merge this for now because it's just a simple exception handling addition.
Please feel free to leave any comments.

@itholic itholic merged commit 18d1d38 into databricks:master Sep 23, 2020
@itholic itholic deleted the fix_from_frame branch October 6, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@itholic