Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Sep 23, 2020

This PR proposes Series.argsort

>>> kser = ks.Series([3, 3, 4, 1, 6, 2, 3, 7, 8, 7, 10])
>>> kser
0      3
1      3
2      4
3      1
4      6
5      2
6      3
7      7
8      8
9      7
10    10
dtype: int64

>>> kser.argsort().sort_index()
0      3
1      5
2      0
3      1
4      6
5      2
6      4
7      7
8      9
9      8
10    10
dtype: int64

@ueshin
Copy link
Collaborator

ueshin commented Sep 23, 2020

The result in the description is different from pandas'.

>>> pd.Series([3, 3, 4, 1, 6, 2, 3, 7, 8, 7, 10]).argsort()
0      3
1      5
2      0
3      1
4      6
5      2
6      4
7      7
8      9
9      8
10    10
dtype: int64

@itholic
Copy link
Contributor Author

itholic commented Sep 24, 2020

The result in the description is different from pandas'.

>>> pd.Series([3, 3, 4, 1, 6, 2, 3, 7, 8, 7, 10]).argsort()
0      3
1      5
2      0
3      1
4      6
5      2
6      4
7      7
8      9
9      8
10    10
dtype: int64

Oh, sorry I should've updated PR description.

@itholic
Copy link
Contributor Author

itholic commented Sep 25, 2020

Thanks, @ueshin !

@itholic
Copy link
Contributor Author

itholic commented Sep 25, 2020

Anyway, I want to include @ueshin as an author for this work.

Maybe merged pull request in my repository is enough, or do I have to do something ??

@itholic
Copy link
Contributor Author

itholic commented Sep 25, 2020

Nvm about #1793 (comment) , think I'll be able to address it !

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could you fix the code conflicts?

@itholic itholic merged commit 7db3571 into databricks:master Sep 26, 2020
@itholic
Copy link
Contributor Author

itholic commented Sep 26, 2020

Oops. why the co-author didn't applied ? Sorry let me figure out the way.

itholic added a commit that referenced this pull request Sep 26, 2020
@itholic itholic deleted the s_argsort branch October 6, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants