Fix the input check in groupby. #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
reviewed
Oct 7, 2020
| ) | ||
|
|
||
| # TODO: a pandas bug? | ||
| # expected = pdf.groupby((10, "a"))[(20, "c")].sum().sort_index() |
Contributor
There was a problem hiding this comment.
nit of nit: one more space here in the comment 😅
Contributor
There was a problem hiding this comment.
Anyway, pdf.groupby((10, "a"))[[(20, "c")]].sum() seems working.
>>> pdf
10 20 30
a b c d
0 1 4 4.0 a
1 2 2 2.0 b
3 6 7 7.0 c
5 4 3 3.0 d
6 4 3 NaN e
8 6 1 1.0 f
9 4 1 1.0 g
9 3 1 1.0 h
9 7 2 2.0 t
>>> pdf.groupby((10, "a"))[[(20, "c")]].sum()
20
c
(10, a)
1 4.0
2 2.0
3 1.0
4 4.0
6 8.0
7 2.0
Contributor
There was a problem hiding this comment.
Oh, Sorry. nvm above. It's different from pdf.groupby((10, "a"))[(20, "c")].sum() anyway.
itholic
reviewed
Oct 7, 2020
Comment on lines
-2348
to
-2351
| self.assertRaises( | ||
| KeyError, | ||
| lambda: kdf.groupby(("B", "class"))[("A", "name")].get_group(["bird", "mammal"]), | ||
| ) |
Contributor
There was a problem hiding this comment.
You removed because this is duplicated test with below ?
Contributor
|
LGTM. Anyway I think it's good to merge regardless of two nit comments. |
itholic
approved these changes
Oct 7, 2020
HyukjinKwon
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the input check in
groupby.