Add return type of to_koalas and to_pandas #1857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
reviewed
Oct 17, 2020
Collaborator
ueshin
left a comment
ueshin
left a comment
There was a problem hiding this comment.
Otherwise, LGTM, pending tests.
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 40 40
Lines 9737 9737
=======================================
Hits 9167 9167
Misses 570 570
Continue to review full report at Codecov.
|
ueshin
reviewed
Oct 17, 2020
ueshin
approved these changes
Oct 17, 2020
Collaborator
|
Thanks! merging. |
Contributor
Author
|
@ueshin Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add return type of to_koalas and to_pandas