-
Notifications
You must be signed in to change notification settings - Fork 367
Simplify plot backend support #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| if isinstance(data, Series): | ||
| positional_args = { | ||
| ("ax", None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this mapping was copied from pandas, which is actually not needed in our case since we're dispatching it in each method e.g.) KoalasPlotAccessor.area.
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
- Coverage 94.60% 94.58% -0.02%
==========================================
Files 49 49
Lines 10890 10866 -24
==========================================
- Hits 10302 10278 -24
Misses 588 588
Continue to review full report at Codecov.
|
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks! merging. |
|
Awesome! |
This PR proposes to simplify plot implementation. Current Koalas implementation attempts to map the argument between other plotting backends (e.g., matplotlib vs plotly). Keeping this map is a huge maintenance cost and it's unrealistic to track their change and keep updating this map.
Pandas itself does not keep this map either: