-
Notifications
You must be signed in to change notification settings - Fork 367
Add min_count parameter for Frame.sum. #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1978 +/- ##
==========================================
- Coverage 94.56% 93.57% -1.00%
==========================================
Files 50 50
Lines 10935 10946 +11
==========================================
- Hits 10341 10243 -98
- Misses 594 703 +109
Continue to review full report at Codecov.
|
itholic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. LGTM
| spark_column = self._internal.spark_column_for(label) | ||
| spark_type = self._internal.spark_type_for(label) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Are we going to add test cases in a separate pr? |
|
I'll fix some corner cases and add tests soon. |
|
Great! LGTM! |
|
Thanks! merging. |
Adds
min_countparameter forFrame.sum.