Skip to content

Conversation

@xinrong-meng
Copy link
Contributor

@xinrong-meng xinrong-meng commented Mar 5, 2021

>>> idx = ks.date_range(start='2018-01', freq='M', periods=3)
>>> idx.month_name()
Index(['January', 'February', 'March'], dtype='object')

>>> idx = ks.date_range(start='2018-01-01', freq='D', periods=3)
>>> idx.day_name()
Index(['Monday', 'Tuesday', 'Wednesday'], dtype='object')

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #2086 (042725a) into master (b32203b) will decrease coverage by 3.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
- Coverage   95.28%   91.49%   -3.79%     
==========================================
  Files          57       57              
  Lines       13227    13119     -108     
==========================================
- Hits        12603    12003     -600     
- Misses        624     1116     +492     
Impacted Files Coverage Δ
databricks/koalas/missing/indexes.py 100.00% <ø> (ø)
databricks/koalas/indexes/datetimes.py 96.00% <100.00%> (-2.35%) ⬇️
databricks/koalas/tests/indexes/test_datetime.py 97.22% <100.00%> (-2.78%) ⬇️
databricks/koalas/plot/plotly.py 15.78% <0.00%> (-81.06%) ⬇️
...bricks/koalas/tests/plot/test_frame_plot_plotly.py 23.33% <0.00%> (-76.67%) ⬇️
...ricks/koalas/tests/plot/test_series_plot_plotly.py 26.92% <0.00%> (-71.26%) ⬇️
databricks/koalas/__init__.py 74.66% <0.00%> (-17.34%) ⬇️
databricks/koalas/missing/__init__.py 84.61% <0.00%> (-15.39%) ⬇️
databricks/koalas/typedef/typehints.py 79.88% <0.00%> (-14.53%) ⬇️
databricks/conftest.py 92.72% <0.00%> (-7.28%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32203b...042725a. Read the comment docs.

@xinrong-meng xinrong-meng requested a review from ueshin March 5, 2021 21:37
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@itholic
Copy link
Contributor

itholic commented Mar 8, 2021

@xinrong-databricks , Let me just merge this to include this change to 1.7.0 release.

Will fix #2086 (comment).

@itholic itholic merged commit 70ba210 into databricks:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants