DataFrame.to_clipboard & Series.to_clipboard #257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 93.57% 93.59% +0.01%
==========================================
Files 33 34 +1
Lines 3286 3325 +39
==========================================
+ Hits 3075 3112 +37
- Misses 211 213 +2
Continue to review full report at Codecov.
|
|
@rxin any idea why |
|
I think it's spurious failure |
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Can we do Series.to_clipboard together while we're here?
|
@HyukjinKwon I added |
garawalid
changed the title
|
New tests in |
| }, index=[0, 1, 3]) | ||
| validate_arguments_and_invoke_function(pdf, self.to_html, pd.DataFrame.to_html, args) | ||
|
|
||
| def to_clipboard(self, sep=',', **kwargs): |
There was a problem hiding this comment.
why is this test case here? this file is for testing functionalities in utils.py
There was a problem hiding this comment.
This test case is for testing **kwargs in validate_arguments_and_invoke_function()
Improve validate_arguments_and_invoke_function() when receiving argument **kwargs
- actual args : {'kwargs': {'index': False}, 'sep': ',', 'excel': True}
- expected args : {'sep': ',', 'excel': True, 'index': False}
|
whoa .. merging others made some conflicts here.. |
|
@HyukjinKwon done! |
|
I'll solve the conflict! |
|
cc @HyukjinKwon |
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks good. Let me double check and get this in today.
Add `DataFrame.to_clipboard` and `Series.to_clipboard`. Part of databricks#169. Improve `validate_arguments_and_invoke_function()` when receiving argument `**kwargs` + actual args : `{'kwargs': {'index': False}, 'sep': ',', 'excel': True}` + expected args : `{'sep': ',', 'excel': True, 'index': False}`
4 participants
Add
DataFrame.to_clipboardandSeries.to_clipboard. Part of #169.Improve
validate_arguments_and_invoke_function()when receiving argument**kwargs{'kwargs': {'index': False}, 'sep': ',', 'excel': True}{'sep': ',', 'excel': True, 'index': False}