Skip to content

Conversation

@floscha
Copy link
Contributor

@floscha floscha commented May 14, 2019

As requested in #264, this PR removes the specific SparkPandasMergeError and replaces its usage with the more generic ValueError.

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #323 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   93.88%   93.87%   -0.01%     
==========================================
  Files          34       34              
  Lines        3350     3347       -3     
==========================================
- Hits         3145     3142       -3     
  Misses        205      205
Impacted Files Coverage Δ
databricks/koalas/exceptions.py 78.12% <ø> (-1.29%) ⬇️
databricks/koalas/tests/test_dataframe.py 100% <100%> (ø) ⬆️
databricks/koalas/frame.py 94.89% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d88e3...36f6044. Read the comment docs.

@rxin
Copy link
Contributor

rxin commented May 14, 2019

Thanks for the quick response. Merging.

@rxin rxin merged commit 372b8a3 into databricks:master May 14, 2019
@floscha floscha deleted the remove-merge-error branch May 27, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants