Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented May 17, 2019

This PR adds base of ks.concat. There are still many parameters to implement existent in Pandas'

Resolves #231

@HyukjinKwon HyukjinKwon changed the title Add ks.concat Add koalas.concat May 17, 2019
@HyukjinKwon HyukjinKwon requested review from rxin and ueshin and removed request for rxin May 17, 2019 04:13
@codecov-io
Copy link

codecov-io commented May 17, 2019

Codecov Report

Merging #348 into master will increase coverage by 0.07%.
The diff coverage is 98.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   94.31%   94.38%   +0.07%     
==========================================
  Files          35       36       +1     
  Lines        3551     3633      +82     
==========================================
+ Hits         3349     3429      +80     
- Misses        202      204       +2
Impacted Files Coverage Δ
databricks/koalas/__init__.py 92.59% <ø> (ø) ⬆️
databricks/koalas/tests/test_namespace.py 100% <100%> (ø)
databricks/koalas/tests/test_dataframe.py 100% <100%> (ø) ⬆️
databricks/koalas/namespace.py 92.95% <97.1%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926400f...88c224c. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented May 20, 2019

Thanks! merging to master.

@ueshin ueshin merged commit 3cffb28 into databricks:master May 20, 2019
@HyukjinKwon HyukjinKwon deleted the concat branch September 11, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

koalas.concat

4 participants