Add DataFrame.astype #349
Merged
Add DataFrame.astype #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
add-astype-dataframe
branch
from
b5d54e1 to
258d69f
Compare
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 94.31% 94.31% -0.01%
==========================================
Files 35 35
Lines 3538 3551 +13
==========================================
+ Hits 3337 3349 +12
- Misses 201 202 +1
Continue to review full report at Codecov.
|
Member
Author
|
Tests passed. |
garawalid
reviewed
May 17, 2019
Contributor
garawalid
left a comment
garawalid
left a comment
There was a problem hiding this comment.
I'd add some tests. LGTM otherwise.
Member
Author
|
Actually, all new codes are covered by doctests except one line that throws an exception (https://codecov.io/gh/databricks/koalas/pull/349/diff?src=pr&el=tree#D4-2632). Should be fine.. |
Member
Author
|
Thanks, @garawalid for review. |
Contributor
|
@HyukjinKwon you are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
DataFrame.astype.Resolves #339