Skip to content

Conversation

@ueshin
Copy link
Collaborator

@ueshin ueshin commented May 20, 2019

This PR adds loc property for DataFrame and Series.
The limitation is that the row access is only allowed to .iloc[:10, ...] (limit(10)) or .iloc[:, ...] (get all rows).
Resolves #247.

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #364 into master will increase coverage by 0.06%.
The diff coverage is 92.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   94.36%   94.43%   +0.06%     
==========================================
  Files          36       36              
  Lines        3657     3754      +97     
==========================================
+ Hits         3451     3545      +94     
- Misses        206      209       +3
Impacted Files Coverage Δ
databricks/koalas/missing/frame.py 100% <ø> (ø) ⬆️
databricks/koalas/missing/series.py 100% <ø> (ø) ⬆️
databricks/koalas/generic.py 94.33% <100%> (+0.16%) ⬆️
databricks/koalas/tests/test_indexing.py 87.5% <88.13%> (+2.24%) ⬆️
databricks/koalas/indexing.py 92.69% <95.38%> (+1.78%) ⬆️
databricks/koalas/__init__.py 88.88% <0%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d310a91...426ada9. Read the comment docs.

@HyukjinKwon
Copy link
Member

+1 ! sorry @ueshin, seems I caused the conflict. Let's get this in first before my other PRs.

@ueshin
Copy link
Collaborator Author

ueshin commented May 20, 2019

@HyukjinKwon no problem! that happens!

@HyukjinKwon HyukjinKwon merged commit 86e74df into databricks:master May 21, 2019
@ueshin ueshin deleted the iloc branch May 21, 2019 04:40
@ueshin ueshin mentioned this pull request May 21, 2019
HyukjinKwon pushed a commit that referenced this pull request May 21, 2019
#364 and #341 cause breaking build due to implementation conflict.
This PR fixes it.
@pwais pwais mentioned this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .iloc support

3 participants