-
Notifications
You must be signed in to change notification settings - Fork 367
Series.dt functions #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Series.dt functions #372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
=========================================
+ Coverage 94.6% 94.6% +<.01%
=========================================
Files 40 41 +1
Lines 4245 4359 +114
=========================================
+ Hits 4016 4124 +108
- Misses 229 235 +6
Continue to review full report at Codecov.
|
|
I have pushed. Will make a separate followup |
|
Thanks @HyukjinKwon ! |
| .. autosummary:: | ||
| :toctree: api/ | ||
|
|
||
| DatetimeMethods.date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon can you figure out how to present the functions similar to pandas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon Please cc me on the PR if you got it working. I banged my head against this for a while :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha same to me too ;D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k, I opened a PR - #404
if the tests pass, i will push two commits . one authored by @icexelloss and one is by me.
I will make a followup to clean up as a separate PR.