Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented May 22, 2019

if the tests pass, i will push two commits . one authored by @icexelloss and one is by me.

I will make a followup to clean up as a separate PR.

@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #372 into master will increase coverage by <.01%.
The diff coverage is 94.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #372      +/-   ##
=========================================
+ Coverage    94.6%   94.6%   +<.01%     
=========================================
  Files          40      41       +1     
  Lines        4245    4359     +114     
=========================================
+ Hits         4016    4124     +108     
- Misses        229     235       +6
Impacted Files Coverage Δ
databricks/koalas/series.py 92.88% <100%> (+0.08%) ⬆️
databricks/koalas/utils.py 100% <100%> (ø) ⬆️
databricks/koalas/typedef.py 80.5% <100%> (+0.12%) ⬆️
databricks/koalas/base.py 89.83% <85.71%> (-0.26%) ⬇️
databricks/koalas/datetime.py 93.44% <93.44%> (ø)
databricks/koalas/tests/test_series_datetime.py 91.8% <97.61%> (+10.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 314aedc...a2a128c. Read the comment docs.

@HyukjinKwon
Copy link
Member Author

I have pushed. Will make a separate followup

@icexelloss
Copy link
Contributor

Thanks @HyukjinKwon !

.. autosummary::
:toctree: api/

DatetimeMethods.date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon can you figure out how to present the functions similar to pandas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon Please cc me on the PR if you got it working. I banged my head against this for a while :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha same to me too ;D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k, I opened a PR - #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants