Rename the default index 'one-by-one' to 'sequence' #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
reviewed
Aug 22, 2019
HyukjinKwon
commented
Aug 22, 2019
| This is conceptually equivalent to the Spark example as below: | ||
| >>> spark_df = ks.range(3).to_spark() | ||
| >>> spark_df.rdd.zipWithIndex().map(lambda p: p[1]).collect() |
Member
Author
There was a problem hiding this comment.
Actually, RDD API is not used in actual index implementation but pandas group-map UDF is being used, and it mimics zipWithIndex in RDD API.
HyukjinKwon
force-pushed
the
rename-to-sequence
branch
from
4224967 to
a527e4e
Compare
Softagram Impact Report for pull/679 (head commit: a527e4e)⭐ Change Overview
📄 Full report
Give feedback on this report to [email protected] |
Member
Author
|
Merged for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a concern about the naming 'one-by-one' since it's confusing (see https://groups.google.com/forum/m/#!topic/koalas-dev/xzZ0VvXFsGM)
This PR proposes to rename the default index 'one-by-one' to 'sequence'.