TST: Add sanity checks for some series plot #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
changed the title
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 93.52% 93.54% +0.01%
==========================================
Files 32 32
Lines 5455 5455
==========================================
+ Hits 5102 5103 +1
+ Misses 353 352 -1
Continue to review full report at Codecov.
|
Softagram Impact Report for pull/687 (head commit: bf91623)⭐ Change Overview
📄 Full report
Give feedback on this report to [email protected] |
HyukjinKwon
approved these changes
Aug 25, 2019
Member
|
What does TST stand for BTW :D? |
Member
|
@itholic, BTW you can start to work on such missing test coverage too. |
Contributor
|
@HyukjinKwon Thanks Hyukjin, I'll try and share it when the results come out! :) |
Contributor
Author
it was short for test xD, just wanna intuitively show this PR is just test fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across
test_series_plot.pyand saw the existing plots might lack sanity check.e.g. if a test
s.plot.line()is added, I think it's also good to have sanity check to see ifs.plot(kind='line')outputs the correct fig (in principle, it of course should).The plots I added are:
line,bar,histandpie.