Skip to content

Conversation

@charlesdong1991
Copy link
Contributor

@charlesdong1991 charlesdong1991 commented Aug 26, 2019

kdf and pdf with specified x and y:

Screen Shot 2019-08-26 at 10 44 59 PM

Screen Shot 2019-08-26 at 10 49 49 PM

kdf and pdf without specified x and y:
Screen Shot 2019-08-26 at 10 46 31 PM

Screen Shot 2019-08-26 at 10 45 22 PM

@charlesdong1991 charlesdong1991 changed the title Add barh plot frame ENH: Add barh plot frame Aug 26, 2019
@charlesdong1991 charlesdong1991 changed the title ENH: Add barh plot frame ENH: Add barh plot for DataFrame Aug 26, 2019
@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #698 into master will decrease coverage by 0.05%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   93.71%   93.65%   -0.06%     
==========================================
  Files          32       32              
  Lines        5523     5534      +11     
==========================================
+ Hits         5176     5183       +7     
- Misses        347      351       +4
Impacted Files Coverage Δ
databricks/koalas/plot.py 94.73% <92.85%> (-0.13%) ⬇️
databricks/koalas/__init__.py 82.05% <0%> (-2.57%) ⬇️
databricks/conftest.py 95.34% <0%> (-2.33%) ⬇️
databricks/koalas/frame.py 94.75% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfaf636...efc8d2b. Read the comment docs.

@charlesdong1991
Copy link
Contributor Author

charlesdong1991 commented Aug 27, 2019

cannot figure out how to resolve codecov issue. 😥

if you could take a look at either barh or bar, once either of them gets merged, I could fix duplicates/conflict for the other one, since there are duplicate codes shared in these two PRs.

@HyukjinKwon
Copy link
Member

It's okay. codecov sometimes looks a bit dumb.

@softagram-bot
Copy link

Softagram Impact Report for pull/698 (head commit: 4e8d32e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to [email protected]

@charlesdong1991
Copy link
Contributor Author

Conflicts are resolved. Let's see if everything can pass. @HyukjinKwon

I think I also need to resolve conflict for another PR once this is merged, so let me do it one by one.

@HyukjinKwon HyukjinKwon merged commit a449894 into databricks:master Aug 27, 2019
@HyukjinKwon
Copy link
Member

Thanks, merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants